support download of UTF-8 filenames #7188 #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 |
qqmyers
reviewed
Jan 8, 2021
src/main/java/edu/harvard/iq/dataverse/api/DownloadInstanceWriter.java
Outdated
Show resolved
Hide resolved
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Jan 11, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If you upload a file to Dataverse with a filename that has UTF-8 characters, they get munged on the download. For example, an en-dash ("-") is replaced by a space. "READ–ME.md" become "READ ME.md".
Which issue(s) this PR closes:
Closes #7188
Special notes for your reviewer:
None.
Suggestions on how to test this:
Emojis seem to work too! 🎉 🎉 🎉
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
I didn't add one but I'd be happy to.
Additional documentation:
None. My guess is that people assume this already works. I don't think we declare support for UTF-8 filenames anywhere. To be honest, I'm surprised it works as well as it does but I guess it is 2021. We're living in the future. 😎